Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate implicit String-to-UTF8-bytes ticket methods #5405

Commits on Apr 24, 2024

  1. Deprecate implicit String-to-UTF8-bytes ticket methods

    The implicit String-to-UTF8-bytes ticket methods are potentially confusing when the user really wants to get a query scoped variable ticket. From the perspective of the java client, this may materialize as errors that look something like:
    
    ```
    Exception in thread "main" io.deephaven.client.impl.TableHandle$UncheckedTableHandleException: io.deephaven.client.impl.TableHandle$TableHandleException: io.grpc.StatusRuntimeException: FAILED_PRECONDITION: Could not resolve 'sourceId': no resolver for route '84' (byte)
    ```
    
    In this case, we can see that the user likely had some variable name that starts with "t" (ascii 84) and tried to use the variable name directly with one of the String-to-UTF8-bytes ticket methods.
    
    This PR aims to deprecates those methods and internally removes any usage that we have on them.
    devinrsmith committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    8ff0783 View commit details
    Browse the repository at this point in the history
  2. cleanup doc

    devinrsmith committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    0c8c14e View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Merge remote-tracking branch 'upstream/main' into ticket-table-deprec…

    …ate-implicit-string-as-utf8-ticket
    devinrsmith committed May 10, 2024
    Configuration menu
    Copy the full SHA
    1f7ca4a View commit details
    Browse the repository at this point in the history