Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect all pydeephaven-ticking wheels into single directory #5444

Merged
merged 2 commits into from
May 2, 2024

Conversation

devinrsmith
Copy link
Member

This matches the expectations and conventions established by publish-ci.yml.

Fixes #5425

This matches the expectations and conventions established by publish-ci.yml.

Fixes deephaven#5425
@devinrsmith devinrsmith requested a review from stanbrub May 1, 2024 22:38
@devinrsmith devinrsmith marked this pull request as ready for review May 1, 2024 22:38
@devinrsmith devinrsmith requested a review from niloc132 May 1, 2024 22:39
@devinrsmith
Copy link
Member Author

While it's hard to test actions fully, I have verified that the pydeephaven-ticking wheels get uploaded to during the "Upload Artifacts". In the case that publishing to PyPi is still in error, we should be able to retrieve and publish manually from the uploaded artifacts. That said, I expect PyPi publishing to succeed.

Copy link
Contributor

@stanbrub stanbrub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes make sense, although I know little about the rest of this script.

@stanbrub stanbrub merged commit d1a0e2b into deephaven:main May 2, 2024
15 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix pydeephaven-ticking release
4 participants