-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arrow Encoding for LocalDate and LocalTime #5446
Arrow Encoding for LocalDate and LocalTime #5446
Conversation
...rrage/src/main/java/io/deephaven/extensions/barrage/chunk/CharChunkInputStreamGenerator.java
Outdated
Show resolved
Hide resolved
...rrage/src/main/java/io/deephaven/extensions/barrage/chunk/CharChunkInputStreamGenerator.java
Outdated
Show resolved
Hide resolved
...rrage/src/main/java/io/deephaven/extensions/barrage/chunk/CharChunkInputStreamGenerator.java
Outdated
Show resolved
Hide resolved
...rrage/src/main/java/io/deephaven/extensions/barrage/chunk/CharChunkInputStreamGenerator.java
Outdated
Show resolved
Hide resolved
...rrage/src/main/java/io/deephaven/extensions/barrage/chunk/CharChunkInputStreamGenerator.java
Show resolved
Hide resolved
...rrage/src/main/java/io/deephaven/extensions/barrage/chunk/CharChunkInputStreamGenerator.java
Outdated
Show resolved
Hide resolved
...s/barrage/src/main/java/io/deephaven/extensions/barrage/chunk/ChunkInputStreamGenerator.java
Outdated
Show resolved
Hide resolved
...s/barrage/src/main/java/io/deephaven/extensions/barrage/chunk/ChunkInputStreamGenerator.java
Outdated
Show resolved
Hide resolved
extensions/barrage/src/main/java/io/deephaven/extensions/barrage/util/BarrageUtil.java
Outdated
Show resolved
Hide resolved
...s/barrage/src/main/java/io/deephaven/extensions/barrage/chunk/ChunkInputStreamGenerator.java
Outdated
Show resolved
Hide resolved
...s/barrage/src/main/java/io/deephaven/extensions/barrage/chunk/ChunkInputStreamGenerator.java
Outdated
Show resolved
Hide resolved
extensions/barrage/src/main/java/io/deephaven/extensions/barrage/util/BarrageUtil.java
Outdated
Show resolved
Hide resolved
extensions/barrage/src/main/java/io/deephaven/extensions/barrage/util/BarrageUtil.java
Show resolved
Hide resolved
...s/barrage/src/main/java/io/deephaven/extensions/barrage/chunk/ChunkInputStreamGenerator.java
Outdated
Show resolved
Hide resolved
...s/barrage/src/main/java/io/deephaven/extensions/barrage/chunk/ChunkInputStreamGenerator.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing the changes in arrow.py
pa.date32(), | ||
pa.timestamp('ns', tz='MST'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like that we don't support pa.timestamp(ns) with a tz, what about just no tz or tz=utc? If we flatly don't support pa.timestamp, maybe we should remove the 'java.time.Instant' mapping?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually the test might be passing now. I suspect the test isn't looking at the time zones. I do think that the data is correct; the timezone is just like a display that applies to all elements. Instant's aren't in a particular time zone in general. Locally I only get lfs and postgres failures; so... we'll find out soon.
Fixes #4823.
Fixes #5265.