-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposed superficial fixes around MutableInt/MutableLong usage #5450
Conversation
...a/io/deephaven/engine/table/impl/asofjoin/RightIncrementalAsOfJoinStateManagerTypedBase.java
Outdated
Show resolved
Hide resolved
7500fb8
to
a066314
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review for commit 1.
...ne/table/src/main/java/io/deephaven/engine/table/impl/by/ChunkedWeightedAverageOperator.java
Outdated
Show resolved
Hide resolved
...a/io/deephaven/engine/table/impl/asofjoin/RightIncrementalAsOfJoinStateManagerTypedBase.java
Outdated
Show resolved
Hide resolved
...ne/table/src/main/java/io/deephaven/engine/table/impl/by/ChunkedWeightedAverageOperator.java
Outdated
Show resolved
Hide resolved
.../table/src/main/java/io/deephaven/engine/table/impl/by/DoubleChunkedWeightedSumOperator.java
Outdated
Show resolved
Hide resolved
...ne/table/src/main/java/io/deephaven/engine/table/impl/by/LongChunkedWeightedSumOperator.java
Outdated
Show resolved
Hide resolved
.../io/deephaven/engine/table/impl/naturaljoin/IncrementalNaturalJoinStateManagerTypedBase.java
Outdated
Show resolved
Hide resolved
...main/java/io/deephaven/engine/table/impl/updateby/hashing/UpdateByStateManagerTypedBase.java
Outdated
Show resolved
Hide resolved
...nsions/barrage/src/main/java/io/deephaven/extensions/barrage/BarrageStreamGeneratorImpl.java
Show resolved
Hide resolved
...nsions/barrage/src/main/java/io/deephaven/extensions/barrage/BarrageStreamGeneratorImpl.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/deephaven/extensions/barrage/chunk/VarBinaryChunkInputStreamGenerator.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit 6 comments. No comments on 2-5.
a066314
to
232b58e
Compare
Updated commit 1, and simple changes to rebase the others to deal with those changes. |
60a0ba2
to
266cc6d
Compare
Util/src/test/java/io/deephaven/util/datastructures/TestSimpleReferenceManager.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trivial comments. Happy to approve regardless of whether you make any changes in response.
One of the failing tests is easy to address:
|
266cc6d
to
d569981
Compare
Added two new commits on the top, rather than try to work them into where they actually go - one restores screwy imports so codegen is "happy", the other reverts back to the apache MutableInt/Long for engine test utils. |
d569981
to
0c69168
Compare
Partial #5412