Proposed superficial fixes around MutableInt/MutableLong usage #5450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niloc132
commented
May 2, 2024
...a/io/deephaven/engine/table/impl/asofjoin/RightIncrementalAsOfJoinStateManagerTypedBase.java
Outdated
Show resolved
Hide resolved
niloc132
force-pushed
the
5412-mutable-int
branch
4 times, most recently
from
7500fb8
to
a066314
Compare
rcaudy
reviewed
May 24, 2024
...ne/table/src/main/java/io/deephaven/engine/table/impl/by/ChunkedWeightedAverageOperator.java
Outdated
Show resolved
Hide resolved
...a/io/deephaven/engine/table/impl/asofjoin/RightIncrementalAsOfJoinStateManagerTypedBase.java
Outdated
Show resolved
Hide resolved
...ne/table/src/main/java/io/deephaven/engine/table/impl/by/ChunkedWeightedAverageOperator.java
Outdated
Show resolved
Hide resolved
.../table/src/main/java/io/deephaven/engine/table/impl/by/DoubleChunkedWeightedSumOperator.java
Outdated
Show resolved
Hide resolved
...ne/table/src/main/java/io/deephaven/engine/table/impl/by/LongChunkedWeightedSumOperator.java
Outdated
Show resolved
Hide resolved
.../io/deephaven/engine/table/impl/naturaljoin/IncrementalNaturalJoinStateManagerTypedBase.java
Outdated
Show resolved
Hide resolved
...main/java/io/deephaven/engine/table/impl/updateby/hashing/UpdateByStateManagerTypedBase.java
Outdated
Show resolved
Hide resolved
...nsions/barrage/src/main/java/io/deephaven/extensions/barrage/BarrageStreamGeneratorImpl.java
Show resolved
Hide resolved
...nsions/barrage/src/main/java/io/deephaven/extensions/barrage/BarrageStreamGeneratorImpl.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/deephaven/extensions/barrage/chunk/VarBinaryChunkInputStreamGenerator.java
Show resolved
Hide resolved
rcaudy
reviewed
May 24, 2024
niloc132
force-pushed
the
5412-mutable-int
branch
from
a066314
to
232b58e
Compare
|
Updated commit 1, and simple changes to rebase the others to deal with those changes. |
niloc132
force-pushed
the
5412-mutable-int
branch
2 times, most recently
from
60a0ba2
to
266cc6d
Compare
rcaudy
reviewed
May 28, 2024
rcaudy
reviewed
May 28, 2024
Util/src/test/java/io/deephaven/util/datastructures/TestSimpleReferenceManager.java
Show resolved
Hide resolved
rcaudy
reviewed
May 28, 2024
|
One of the failing tests is easy to address: |
niloc132
force-pushed
the
5412-mutable-int
branch
from
266cc6d
to
d569981
Compare
|
Added two new commits on the top, rather than try to work them into where they actually go - one restores screwy imports so codegen is "happy", the other reverts back to the apache MutableInt/Long for engine test utils. |
niloc132
force-pushed
the
5412-mutable-int
branch
from
d569981
to
0c69168
Compare
rcaudy
approved these changes
May 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial #5412