Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logging when a ReplayTableBase has an error during refresh #5454

Merged
merged 1 commit into from
May 3, 2024
Merged

Add logging when a ReplayTableBase has an error during refresh #5454

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions engine/table/src/main/java/io/deephaven/engine/table/impl/replay/ReplayTableBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,16 @@
import io.deephaven.engine.table.ColumnSource;
import io.deephaven.engine.table.impl.InstrumentedTableUpdateSource;
import io.deephaven.engine.table.impl.QueryTable;
import io.deephaven.internal.log.LoggerFactory;
import io.deephaven.io.logger.Logger;
import org.jetbrains.annotations.NotNull;

import java.util.Map;

public abstract class ReplayTableBase extends QueryTable implements Runnable {

private static final Logger log = LoggerFactory.getLogger(ReplayTableBase.class);

private final SourceRefresher sourceRefresher;

public ReplayTableBase(
Expand Down Expand Up @@ -41,5 +45,11 @@ private class SourceRefresher extends InstrumentedTableUpdateSource {
protected void instrumentedRefresh() {
ReplayTableBase.this.run();
}

@Override
protected void onRefreshError(@NotNull final Exception error) {
log.error().append("Error refreshing ").append(ReplayTableBase.this).append(": ").append(error).endl();
super.onRefreshError(error);
}
}
}
Loading