-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Local Smoke Tests by Allowing ScriptSessionCacheInit's mkdir to Race in Parallel Tests #5465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly NoConsoleSessionModule
rcaudy
reviewed
May 8, 2024
server/src/test/java/io/deephaven/server/runner/DeephavenApiServerTestBase.java
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/console/NoConsoleSessionModule.java
Outdated
Show resolved
Hide resolved
This feels like we're working around the fact that our processes expect exclusive ownership of their "cache" directory. |
I'm getting this too, which ultimately causes teardown NPEs.
I'm able to workaround it right now by setting |
rcaudy
approved these changes
May 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that
NoConsoleSessionModule
is used in the testing context and if we simply do not require theScriptSessionCacheInit
then it no longer fails. I've left a few null checks in tearDown that fix cascading failures when setUp throws an exception in a super class.