Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish deephaven-server-test jar #5467

Merged

Conversation

devinrsmith
Copy link
Member

Ultimately, this PR makes the server-test jar public so external integrators can write unit tests against it. As part of this effort, all transitive dependencies of server-test need to be made public as well. test-configs was elevated to a public jar, and in other cases, "test library code" was extracted from "test code" (in these cases, we already had appropriate public testing jars the code could be moved to).

Fixes #5341

chipkent
chipkent previously approved these changes May 10, 2024
Copy link
Member

@chipkent chipkent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but a gradle expert should also check.

Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest server-test -> server-test-utils to mirror engine-test-utils (our other public test utility module).

@devinrsmith devinrsmith merged commit a1371c0 into deephaven:main May 14, 2024
14 checks passed
@devinrsmith devinrsmith deleted the nightly/publish-testing-libraries branch May 14, 2024 23:21
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish utilities to assist in writing unit tests
3 participants