-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish deephaven-server-test jar #5467
Publish deephaven-server-test jar #5467
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but a gradle expert should also check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest server-test -> server-test-utils to mirror engine-test-utils (our other public test utility module).
Ultimately, this PR makes the
server-test
jar public so external integrators can write unit tests against it. As part of this effort, all transitive dependencies ofserver-test
need to be made public as well.test-configs
was elevated to a public jar, and in other cases, "test library code" was extracted from "test code" (in these cases, we already had appropriate public testing jars the code could be moved to).Fixes #5341