Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded version for parquet-hadoop #5469

Merged
merged 1 commit into from
May 22, 2024
Merged

Upgraded version for parquet-hadoop #5469

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion buildSrc/src/main/groovy/Classpaths.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ class Classpaths {

static void inheritParquetHadoop(Project p, String configName = JavaPlugin.IMPLEMENTATION_CONFIGURATION_NAME) {
Configuration config = p.configurations.getByName(configName)
addDependency(config, 'org.apache.parquet', 'parquet-hadoop', '1.13.1')
addDependency(config, 'org.apache.parquet', 'parquet-hadoop', '1.14.0')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should investigate what the release notes means for:

PARQUET-1822 - Parquet without Hadoop dependencies

that would be quite nice if we don't need some of the hadoop deps.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was looking at the linked changes and the main commit seems like this: https://github.com/apache/parquet-mr/pull/1141/files#diff-b044ae9879a94e2b8a49d6e6911ea5498ef162df1373cc049ded6256980a7248

One interesting class they have now added are org.apache.parquet.conf.PlainParquetConfiguration to replace org.apache.hadoop.conf.Configuration.

Some other interesting classes that I noticed are

  • org.apache.parquet.hadoop.CodecFactory which can potentially replace the usage of org.apache.hadoop.io.compress.CompressionCodecFactory.
  • org.apache.parquet.hadoop.CodecFactory.HeapBytesCompressor which can replace org.apache.hadoop.io.compress.Compressor
  • org.apache.parquet.hadoop.CodecFactory.HeapBytesDecompressor which can replace org.apache.hadoop.io.compress.Decompressor

I think there is enough here so we can get rid of the hadoop-common dependencies. We would still need parquet-hadoop though which internally would be using hadoop-common only.
Do you think that would be beneficial?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so, yes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Is it okay if I make a separate issue for this?
This would require some dedicated effort for the change as well as for the benchmarking.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created this issue: #5517

}

/** configName controls only the Configuration's classpath, all transitive dependencies are runtimeOnly */
Expand Down
Loading