Provide Gradle toolchain resolver implementation #5475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niloc132
added
build
NoDocumentationNeeded
NoReleaseNotesNeeded
devinrsmith
approved these changes
May 10, 2024
There was a problem hiding this comment.
I did notice when gradle started adding this plugin to their "gradle init" setup; I didn't dig deeper, and always removed it. Not something I noticed since I always run with org.gradle.java.installations.auto-download=false. I will follow-up with some developer notes wrt deephaven/deephaven-docs-community#205.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems Gradle 8.2 changed how autoprovisioning toolkits works, but without any warning/error, just missing behavior and a one line mention in the release notes. Adding the foojay resolver plugin to our settings files makes it possible to again download JDKs automatically as needed.
Also adds debugging detail to the newly added SafetyChecks.