Don't close long-lived RowSets in Downsampler BucketState #5478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug in downsampling where a table may cause an error if freed while processing an update. Fixes deephaven#5476
niloc132
added
plotting
NoDocumentationNeeded
ReleaseNotesNeeded
rcaudy
reviewed
May 10, 2024
ClientSupport/src/main/java/io/deephaven/clientsupport/plotdownsampling/BucketState.java
Outdated
Show resolved
Hide resolved
rcaudy
reviewed
May 10, 2024
ClientSupport/src/main/java/io/deephaven/clientsupport/plotdownsampling/BucketState.java
Show resolved
Hide resolved
rcaudy
changed the title
niloc132
force-pushed
the
5476-downsample-use-after-close
branch
from
f0dd72d
to
a6a31b8
Compare
rcaudy
approved these changes
May 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in downsampling where a table may cause an error if freed while processing an update.
Fixes #5476