Free performance data when ExportObject is released #5480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cuts leaked memory from released objects by around 50%. Partial deephaven#5479
niloc132
added
NoDocumentationNeeded
ReleaseNotesNeeded
rcaudy
reviewed
May 10, 2024
| @@ -1141,6 +1141,7 @@ protected synchronized void destroy() { | |||
| if (!(caughtException instanceof StatusRuntimeException)) { | |||
| caughtException = null; | |||
| } | |||
| queryPerformanceRecorder = null; | |||
There was a problem hiding this comment.
What is the goal here? I assume we're not keeping hard refs to the ExportObject once it's destroyed most of the time, anyway.
There was a problem hiding this comment.
At this time, we do keep hard refs to ExportObjects within a session so that we can tell if an unrecognized export ID is either stale RELEASED ("sorry, you raced but you just missed it, that was already released") or UNKNOWN ("hmm, never seen that before, you probably raced it and won, so we'll wait until it appears").
The linked issue mentions a strategy to handle this, with a RowSet for known-released objects, so that we no longer need to keep the ExportObject itself around.
nbauernfeind
approved these changes
May 16, 2024
rcaudy
approved these changes
May 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cuts leaked memory from released objects by around 50%.
Partial #5479