Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump base images #5481

Merged
merged 3 commits into from
May 13, 2024
Merged

Conversation

devinrsmith
Copy link
Member

No description provided.

Causes compile error, may need to bump proto java version

```
2024-05-10T22:00:28.9028228Z > Task :proto:proto-backplane-grpc:compileJava
2024-05-10T22:00:28.9039719Z /home/runner/work/deephaven-core/deephaven-core/proto/proto-backplane-grpc/build/generated/source/proto/main/java/io/deephaven/proto/backplane/grpc/ConfigurationConstantsResponse.java:38: error: cannot find symbol
2024-05-10T22:00:28.9049578Z   protected com.google.protobuf.MapFieldReflectionAccessor internalGetMapFieldReflection(
...
```
Causes the error

```
2024-05-10T22:12:03.1202310Z npm ERR! notsup Required: {"node":"20.10.0","npm":"10.2.3"}
2024-05-10T22:12:03.1206103Z npm ERR![0m[91m notsup Actual:   {"npm":"10.5.2","node":"v20.13.1"}
```
@devinrsmith devinrsmith marked this pull request as ready for review May 11, 2024 04:44
@devinrsmith devinrsmith self-assigned this May 11, 2024
@devinrsmith devinrsmith added this to the 3. May 2024 milestone May 11, 2024
connectorx==0.3.2; platform.machine == 'x86_64'
deephaven-plugin==0.6.0
java-utilities==0.2.0
importlib_resources==6.4.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this new dependency needed for?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea. Something transitively depends on it now so we pick it up.

@devinrsmith devinrsmith merged commit 638c1df into deephaven:main May 13, 2024
16 of 19 checks passed
@devinrsmith devinrsmith deleted the nightly/bump_images branch May 13, 2024 22:29
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants