Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove branching in UDF wrappers via. code gen #5487

Merged
merged 5 commits into from
May 24, 2024
Merged

Remove branching in UDF wrappers via. code gen #5487

merged 5 commits into from
May 24, 2024

Conversation

jmao-denver
Copy link
Contributor

Fixes #5460

@jmao-denver jmao-denver added this to the 3. May 2024 milestone May 14, 2024
@jmao-denver jmao-denver self-assigned this May 14, 2024
@jmao-denver jmao-denver changed the title Optimize UDF vectorization wrapper by reducing unnecessary checks Optimize UDF vectorization wrapper by reducing the number of checks May 14, 2024
@jmao-denver jmao-denver force-pushed the 5460-udf-vectorization-optimization branch from ab51a8e to 44ed818 Compare May 14, 2024 17:41
@jmao-denver jmao-denver marked this pull request as ready for review May 14, 2024 20:32
chipkent
chipkent reviewed May 16, 2024
View reviewed changes
Copy link
Member

@chipkent chipkent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it still looks like there are a lot of branching cases in decorators where the branch case is known at compile time.

py/server/deephaven/_udf.py Outdated Show resolved Hide resolved
py/server/deephaven/_udf.py Outdated Show resolved Hide resolved
py/server/deephaven/_udf.py Outdated Show resolved Hide resolved
py/server/deephaven/_udf.py Outdated Show resolved Hide resolved
py/server/deephaven/_udf.py Outdated Show resolved Hide resolved
py/server/deephaven/_udf.py Outdated Show resolved Hide resolved
py/server/deephaven/_udf.py Outdated Show resolved Hide resolved
@jmao-denver jmao-denver marked this pull request as draft May 20, 2024 19:18
@jmao-denver jmao-denver changed the title Optimize UDF vectorization wrapper by reducing the number of checks Remove branching in wrappers via. code gen May 20, 2024
@jmao-denver jmao-denver marked this pull request as ready for review May 21, 2024 02:34
@jmao-denver jmao-denver changed the title Remove branching in wrappers via. code gen Remove branching in UDF wrappers via. code gen May 21, 2024
@jmao-denver jmao-denver requested a review from chipkent May 21, 2024 03:10
chipkent
chipkent reviewed May 21, 2024
View reviewed changes
py/server/deephaven/_udf.py Show resolved Hide resolved
py/server/deephaven/_udf.py Outdated Show resolved Hide resolved
py/server/deephaven/_udf.py Show resolved Hide resolved
py/server/deephaven/_udf.py Show resolved Hide resolved
py/server/deephaven/_udf.py Show resolved Hide resolved
py/server/deephaven/_udf.py Show resolved Hide resolved
@jmao-denver jmao-denver merged commit 2929e94 into deephaven:main May 24, 2024
15 checks passed
@jmao-denver jmao-denver deleted the 5460-udf-vectorization-optimization branch May 24, 2024 18:28
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chipkent chipkent chipkent approved these changes

@rcaudy rcaudy Awaiting requested review from rcaudy rcaudy is a code owner

Assignees

@jmao-denver jmao-denver

Labels
NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. python-server-side
Projects
None yet
Milestone
3. May 2024
Development

Successfully merging this pull request may close these issues.

Py UDF vectorization should be further optimized.
2 participants
@jmao-denver @chipkent