Bugfix in URI conversion when working with directories #5493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malhotrashivam
added
bug
devinrsmith
reviewed
May 15, 2024
rcaudy
previously approved these changes
May 15, 2024
devinrsmith
reviewed
May 16, 2024
devinrsmith
requested changes
May 16, 2024
devinrsmith
approved these changes
May 16, 2024
malhotrashivam
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the conversion code for String -> URI when working with directories.
This bug could lead to failure in reading flat partitioned parquet files from S3 using a URI which doesn't end with a
\character.