Small ring chunk source cleanup #5502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces the type checking for ring table chunk sources; essentially, matching the expectations that we might need to copy around empty `Object[0]` as a substitute for the more specifically typed empty array. While I'm not the biggest fan of persisting this (ab)use of the type system, it is out of scope to actually try and plumb correct typing throughout the stack at this time. Fixes deephaven#5498
devinrsmith
added
NoDocumentationNeeded
NoReleaseNotesNeeded
|
I guess this use of the type system, while (ab)using |
rcaudy
reviewed
May 16, 2024
| @@ -73,7 +73,13 @@ public AbstractRingChunkSource(@NotNull Class<T> type, int capacity) { | |||
| } | |||
| this.capacity = capacity; | |||
| // noinspection unchecked | |||
| ring = (ARRAY) Array.newInstance(type, capacity); | |||
| ring = type.isArray() | |||
There was a problem hiding this comment.
I think the wider issue here is that this code is using reflection to determine the array type instead of using inheritance (and using Object[] to hold non-primitive values).
There was a problem hiding this comment.
Are you certain you shouldn't be using Object[] in more cases?
There was a problem hiding this comment.
Never mind, we figured out that we were dealing with weird upstream data.
devinrsmith
changed the title
rcaudy
reviewed
May 16, 2024
rcaudy
approved these changes
May 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally explored as a fix for #5498; ultimately, it was an upstream data issue that was solved in #5503. Along the way though, it was noted that ring chunk sources were 1) using reflection in places they didn't need to, and 2) using specifically typed arrays for generic types as opposed to other object chunks which use
Object[]at the top layer. In the latest iteration of this, the construction reflection was removed (there is a new getLength check); but I'm apt to keep the more specifically typed arrays unless we know they are causing other issues. At a minimum, the specifically typed arrays helped us notice and fix #5503.