FlightMessageRoundTripTest: Inner List Type Should not Have Deephaven Type Metadata #5504
Conversation
nbauernfeind
added
core
| final Field payload = new Field("", new FieldType(false, Types.MinorType.FLOAT8.getType(), null), null); | ||
|
|
||
| final FieldType innerFieldType = new FieldType(true, Types.MinorType.LIST.getType(), null); | ||
| final Field inner = new Field("", innerFieldType, Collections.singletonList(payload)); |
There was a problem hiding this comment.
As part of #5497, I'd hoping we can consolidate this sort of building logic into a common place.
For example, should we have innerFieldType with deephaven:type "double[]"? Should payload have type deephaven:type "double"? It might be extraneous today, but may be helpful in the future?
There was a problem hiding this comment.
For this particular test, I would like to remove the type metadata once the barrage reader/writer has access to the Schema during decoding. Right now we can't actually support array types without the deephaven type annotation because we would only know that it's a list and not the type of list. Maybe I could split the test into two and make sure both inferred types and explicit types work happily together.
I would be fine if these were defined some place accessible to both java-client impl and the barrage tests. (but, do eventually think we should support the implicit decoding without type metadata)
No description provided.