-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Breaking] Deleted deprecated parquet read/write APIs #5510
Merged
malhotrashivam
merged 4 commits into
deephaven:main
from
malhotrashivam:sm-ptools-cleanup
Jun 6, 2024
Merged
[Breaking] Deleted deprecated parquet read/write APIs #5510
malhotrashivam
merged 4 commits into
deephaven:main
from
malhotrashivam:sm-ptools-cleanup
Jun 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcaudy
reviewed
May 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
.../src/test/java/io/deephaven/engine/table/impl/locations/impl/TestSourceTableDataIndexes.java
Outdated
Show resolved
Hide resolved
jmao-denver
reviewed
May 21, 2024
chipkent
reviewed
May 21, 2024
jmao-denver
approved these changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Python changes LGTM
chipkent
approved these changes
May 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
breaking
NoDocumentationNeeded
NoReleaseNotesNeeded
No release notes are needed.
parquet
Related to the Parquet integration
release blocker
A bug/behavior that puts is below the "good enough" threshold to release.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up work from #5358 (more details there).
This is a breaking change, since we are deleting deprecated public APIs.