Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: wavg() and wsum() Numeric functions return null when provided a vector containing only null values #5524

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

lbooker42
Copy link
Contributor

@lbooker42 lbooker42 commented May 23, 2024

BREAKING CHANGE: Updates Numeric.ftl wsum() and wavg() to return null when provided a non-empty vector containing only null values.

Closes #5523

@lbooker42 lbooker42 added bug Something isn't working query engine labels May 23, 2024
@lbooker42 lbooker42 added this to the 3. May 2024 milestone May 23, 2024
@lbooker42 lbooker42 self-assigned this May 23, 2024
rcaudy
rcaudy previously approved these changes May 24, 2024
@chipkent chipkent added ReleaseNotesNeeded Release notes are needed breaking and removed NoReleaseNotesNeeded No release notes are needed. labels May 24, 2024
@chipkent chipkent changed the title Initial commit of wavg() and wsum() Numeric function result changes fix!: wavg() and wsum() Numeric functions return null when provided a vector containing only null values May 24, 2024
chipkent
chipkent previously approved these changes May 24, 2024
@lbooker42 lbooker42 dismissed stale reviews from chipkent and rcaudy via 4af6774 May 28, 2024 15:23
@lbooker42
Copy link
Contributor Author

Outstanding changes to these libraries are referred to in this ticket: #5564

@lbooker42 lbooker42 merged commit fd08f4a into deephaven:main Jun 4, 2024
15 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2024
@lbooker42 lbooker42 deleted the lab-numeric-wops branch June 26, 2024 19:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Numeric wavg/wsum functions to return null with all-null input
3 participants