Add defensive bearer token rotation for java client #5539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves a theoretical flashing issue that could arise during token rotation where, depending on the order of responses from the server, a bearer token could be rotated to the new value and then "rotated" back to the old token value. While this situation does not cause an issue with our current server implementation (which is rather lenient and keeps around multiple previous bearer tokens), we should still prefer to be defensive on the java client side and use the newest value.
devinrsmith
added
NoDocumentationNeeded
java-client
NoReleaseNotesNeeded
nbauernfeind
approved these changes
Jun 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves a theoretical flashing issue that could arise during token rotation where, depending on the order of responses from the server, a bearer token could be rotated to the new value and then "rotated" back to the old token value. While this situation does not cause an issue with our current server implementation (which is rather lenient and keeps around multiple previous bearer tokens), we should still prefer to be defensive on the java client side and use the newest value.