Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address missing DateTimeUtils functionality for LocalDateTime #5540

Merged
merged 11 commits into from
Jun 7, 2024
Merged

Address missing DateTimeUtils functionality for LocalDateTime #5540

merged 11 commits into from
Jun 7, 2024

Conversation

rcaudy
Copy link
Member

@rcaudy rcaudy commented May 28, 2024

No description provided.

rcaudy added 10 commits May 28, 2024 18:58
@rcaudy
Add DateTimeUtils.toInstant and toZonedDateTime from LocalDateTime
176458b
@rcaudy
Rename boolean "localTime" function arguments in DateTimeUtils to "as…
b0a7e47 
…LocalTime" and slightly enhance documentation
@rcaudy
For all xOfDay(LocalTime) methods, add an xOfDay(LocalDateTime) overl…
03bfb8a 
…oad. Correct implementations to be more efficient where possible.
@rcaudy
Implement DateTimeUtils.toLocalDate and toLocaleTime from LocalDateTime
56c9e3f
@rcaudy
Methods for going from ZonedDateTime, Instant, or LocalDate+LocalTime…
0fb9818 
… to LocalDateTime
@rcaudy
For most DateTimeUtils methods that take a LocalDate, implement the L…
459e6d2 
…ocalDateTime equivalent. Fix some documentation issues.
@rcaudy
Add missing @ScriptApi annotations in DateTimeUtils
5f35370
@rcaudy
Pedantically "standardize" order of @deprecated annotations in DateTi…
0646981 
…meUtils
@rcaudy
Two trivial isEmpty changes in DateTimeUtils.parseDuration
430b2f9
@rcaudy
Unit tests for all new methods in DateTimeUtils
3be6b48
@rcaudy rcaudy added core Core development tasks NoDocumentationNeeded ReleaseNotesNeeded Release notes are needed labels May 28, 2024
@rcaudy rcaudy added this to the 3. May 2024 milestone May 28, 2024
@rcaudy rcaudy requested a review from chipkent May 28, 2024 22:59
@rcaudy rcaudy self-assigned this May 28, 2024
chipkent
chipkent approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@chipkent chipkent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved assuming there is a follow-on ticket for the open items.

@rcaudy rcaudy mentioned this pull request Jun 7, 2024
Open
@rcaudy rcaudy merged commit 070dc29 into deephaven:main Jun 7, 2024
15 checks passed
@rcaudy rcaudy deleted the rwc-ldt branch June 7, 2024 21:17
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chipkent chipkent chipkent approved these changes

Assignees

@rcaudy rcaudy

Labels
core Core development tasks NoDocumentationNeeded ReleaseNotesNeeded Release notes are needed
Projects
None yet
Milestone
3. May 2024
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rcaudy @chipkent