Barrage: Coalesce UncoalescedTables Prior to Subscribing/Fetching Data #5541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbauernfeind
added
bug
rcaudy
reviewed
May 29, 2024
There was a problem hiding this comment.
I prefer unconditional .coalesce() on Table objects, rather than an instanceof UncoalescedTable check. That better matches the public API design. The assumption that the result is a BaseTable (really, a QueryTable) is also valid for all existing implementations.
server/src/main/java/io/deephaven/server/arrow/ArrowFlightUtil.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/arrow/ArrowFlightUtil.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/arrow/ArrowFlightUtil.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Ryan Caudy <rcaudy@gmail.com>
rcaudy
approved these changes
May 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5538