-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retire DataColumn and replace usages #5553
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Python changes LGTM. Two questions:
- what's the performance implication of this change?
- w/o reading the Java changes, can ColumnVectors be sliced (without flattening)?
… tests, and enable a pattern for "long-lived" chunk allocations that should not be tracked in the ChunkPoolReleaseTracking, applied to RowSet chunk views.
|
Yes,and I was thinking of using it as a way to give Python users the ability of reading the column data (single cell or range/slice) without needing to go through |
I'm unsure. You're still dealing with a JNI access per cell if you just use |
This is what I had in mind very roughly:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plotting and py LGTM. Let me know if I need to review more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skipped the python files, trusting @jmao-denver. Looks good, couple of comments for clarification.
Plot/src/main/java/io/deephaven/plot/util/tables/ColumnHandlerFactory.java
Show resolved
Hide resolved
engine/table/src/test/java/io/deephaven/engine/table/impl/QueryTableAggregationTest.java
Show resolved
Hide resolved
engine/table/src/test/java/io/deephaven/engine/table/impl/TestPartitionAwareSourceTable.java
Outdated
Show resolved
Hide resolved
out.write(separatorStr); | ||
} else { | ||
out.write("\n"); | ||
} | ||
final Object o = cols[j].get(i); | ||
final Object o = cols[ci].get(rowKey); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mentioned we might make this work chunky.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python and plotting LGTM
Labels indicate documentation is required. Issues for documentation have been opened: Community: deephaven/deephaven-docs-community#227 |
No description provided.