fix: Expose layoutHints in JS API for TreeTable #5555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mofojed
commented
Jun 2, 2024
•
mofojed
commented
- You could set layout hints in Groovy, but they were not accessible through the JS API
- Required for DH-17076
- Needs UI change fix: DH-17076 LayoutHints on TreeTables were not being applied web-client-ui#2041
- Refactored from fix: Allow LayoutHints to be accessible from Python, TreeTables #5543 , only the JS API part
- You could set layout hints in Groovy, but they were not accessible through the JS API - Required for DH-17076
mofojed
added
NoDocumentationNeeded
NoReleaseNotesNeeded
This was referenced Jun 2, 2024
mofojed
added a commit
to deephaven/web-client-ui
that referenced
this pull request
Jun 3, 2024
- Related to DH-17076 - Needed a Core patch: deephaven/deephaven-core#5555 - Tested using both the Groovy snippet from the ticket - Fixes #2035
niloc132
approved these changes
Jun 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.