Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added support for parallel snapshot #5558

Merged
merged 27 commits into from
Aug 2, 2024
Merged

feat: Added support for parallel snapshot #5558

merged 27 commits into from
Aug 2, 2024

Conversation

malhotrashivam
Copy link
Contributor

@malhotrashivam malhotrashivam commented Jun 3, 2024 •
edited
Loading

Closes #5551

@malhotrashivam malhotrashivam added feature request New feature or request query engine core Core development tasks NoDocumentationNeeded ReleaseNotesNeeded Release notes are needed labels Jun 3, 2024
@malhotrashivam malhotrashivam added this to the 3. May 2024 milestone Jun 3, 2024
@malhotrashivam malhotrashivam self-assigned this Jun 3, 2024
lbooker42
lbooker42 reviewed Jun 3, 2024
View reviewed changes
Copy link
Contributor

@lbooker42 lbooker42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parallelism looks correct, minor notes otherwise.

engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java Outdated Show resolved Hide resolved
rcaudy
rcaudy reviewed Jun 7, 2024
View reviewed changes
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java Outdated Show resolved Hide resolved
rcaudy
rcaudy reviewed Jun 11, 2024
View reviewed changes
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java Outdated Show resolved Hide resolved
@malhotrashivam malhotrashivam mentioned this pull request Jun 14, 2024
Draft
nbauernfeind
nbauernfeind reviewed Jun 25, 2024
View reviewed changes
.../table/src/main/java/io/deephaven/engine/exceptions/ColumnSnapshotUnsuccessfulException.java Show resolved Hide resolved
...able/src/main/java/io/deephaven/engine/table/impl/OperationInitializationThreadPoolBase.java Outdated Show resolved Hide resolved
...able/src/main/java/io/deephaven/engine/table/impl/OperationInitializationThreadPoolBase.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java Outdated Show resolved Hide resolved
engine/table/src/test/java/io/deephaven/engine/table/impl/QueryTableTest.java Outdated Show resolved Hide resolved
engine/table/src/test/java/io/deephaven/engine/table/impl/QueryTableTest.java Outdated Show resolved Hide resolved
server/src/main/java/io/deephaven/server/arrow/FlightServiceGrpcImpl.java Outdated Show resolved Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java Outdated Show resolved Hide resolved
@malhotrashivam malhotrashivam changed the title Added support for parallel snapshot feat: Added support for parallel snapshot Jul 9, 2024
rcaudy
rcaudy reviewed Aug 1, 2024
View reviewed changes
engine/table/src/main/java/io/deephaven/engine/table/impl/util/BarrageMessage.java Outdated Show resolved Hide resolved
engine/table/src/test/java/io/deephaven/engine/table/impl/QueryTableTest.java Outdated Show resolved Hide resolved
engine/table/src/test/java/io/deephaven/engine/table/impl/QueryTableTest.java Outdated Show resolved Hide resolved
engine/table/src/test/java/io/deephaven/engine/table/impl/QueryTableTest.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java Outdated Show resolved Hide resolved
@malhotrashivam malhotrashivam merged commit beecac5 into deephaven:main Aug 2, 2024
16 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lbooker42 lbooker42 lbooker42 left review comments

@rcaudy rcaudy rcaudy approved these changes

@nbauernfeind nbauernfeind Awaiting requested review from nbauernfeind

Assignees

@malhotrashivam malhotrashivam

Labels
core Core development tasks feature request New feature or request NoDocumentationNeeded query engine ReleaseNotesNeeded Release notes are needed
Projects
None yet
Milestone
3. May 2024
Development

Successfully merging this pull request may close these issues.

Multi-threaded table snapshot operation
4 participants
@malhotrashivam @nbauernfeind @lbooker42 @rcaudy