-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added support for parallel snapshot #5558
Merged
malhotrashivam
merged 27 commits into
deephaven:main
from
malhotrashivam:sm-parallel-snapshot
Aug 2, 2024
Merged
feat: Added support for parallel snapshot #5558
malhotrashivam
merged 27 commits into
deephaven:main
from
malhotrashivam:sm-parallel-snapshot
Aug 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malhotrashivam
added
feature request
New feature or request
query engine
core
Core development tasks
NoDocumentationNeeded
ReleaseNotesNeeded
Release notes are needed
labels
Jun 3, 2024
rcaudy
reviewed
Jun 3, 2024
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java
Outdated
Show resolved
Hide resolved
lbooker42
reviewed
Jun 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parallelism looks correct, minor notes otherwise.
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java
Outdated
Show resolved
Hide resolved
nbauernfeind
reviewed
Jun 4, 2024
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java
Outdated
Show resolved
Hide resolved
nbauernfeind
reviewed
Jun 4, 2024
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java
Outdated
Show resolved
Hide resolved
rcaudy
reviewed
Jun 7, 2024
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java
Outdated
Show resolved
Hide resolved
rcaudy
reviewed
Jun 11, 2024
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java
Outdated
Show resolved
Hide resolved
rcaudy
reviewed
Jun 11, 2024
.../table/src/main/java/io/deephaven/engine/table/impl/GUISnapshotInitializationThreadPool.java
Outdated
Show resolved
Hide resolved
…n discussion with Nate This reverts commit 509d5dd.
.../table/src/main/java/io/deephaven/engine/exceptions/ColumnSnapshotUnsuccessfulException.java
Show resolved
Hide resolved
...able/src/main/java/io/deephaven/engine/table/impl/OperationInitializationThreadPoolBase.java
Outdated
Show resolved
Hide resolved
...able/src/main/java/io/deephaven/engine/table/impl/OperationInitializationThreadPoolBase.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java
Outdated
Show resolved
Hide resolved
engine/table/src/test/java/io/deephaven/engine/table/impl/QueryTableTest.java
Outdated
Show resolved
Hide resolved
engine/table/src/test/java/io/deephaven/engine/table/impl/QueryTableTest.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/arrow/FlightServiceGrpcImpl.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java
Outdated
Show resolved
Hide resolved
malhotrashivam
changed the title
Added support for parallel snapshot
feat: Added support for parallel snapshot
Jul 9, 2024
rcaudy
reviewed
Jul 11, 2024
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java
Outdated
Show resolved
Hide resolved
rcaudy
reviewed
Jul 17, 2024
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java
Outdated
Show resolved
Hide resolved
rcaudy
reviewed
Jul 19, 2024
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/runner/updategraph/UpdateGraphModule.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageMessageProducer.java
Outdated
Show resolved
Hide resolved
rcaudy
reviewed
Aug 1, 2024
engine/table/src/main/java/io/deephaven/engine/table/impl/util/BarrageMessage.java
Outdated
Show resolved
Hide resolved
engine/table/src/test/java/io/deephaven/engine/table/impl/QueryTableTest.java
Outdated
Show resolved
Hide resolved
engine/table/src/test/java/io/deephaven/engine/table/impl/QueryTableTest.java
Outdated
Show resolved
Hide resolved
engine/table/src/test/java/io/deephaven/engine/table/impl/QueryTableTest.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/remote/ConstructSnapshot.java
Outdated
Show resolved
Hide resolved
rcaudy
approved these changes
Aug 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
core
Core development tasks
feature request
New feature or request
NoDocumentationNeeded
query engine
ReleaseNotesNeeded
Release notes are needed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5551