-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a listener that only fires when all dependencies are satisfied #5571
Merged
jmao-denver
merged 8 commits into
deephaven:main
from
jmao-denver:5366-multitable-listener
Jun 18, 2024
Merged
Add a listener that only fires when all dependencies are satisfied #5571
jmao-denver
merged 8 commits into
deephaven:main
from
jmao-denver:5366-multitable-listener
Jun 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a3c8379
to
f137328
Compare
f137328
to
92c54e4
Compare
rcaudy
reviewed
Jun 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly reviewed Java, to avoid redundant work with Chip.
Integrations/src/main/java/io/deephaven/integrations/python/PythonReplayListenerAdapter.java
Outdated
Show resolved
Hide resolved
Integrations/src/main/java/io/deephaven/integrations/python/PythonReplayListenerAdapter.java
Outdated
Show resolved
Hide resolved
Integrations/src/main/java/io/deephaven/integrations/python/PythonReplayListenerAdapter.java
Outdated
Show resolved
Hide resolved
chipkent
requested changes
Jun 10, 2024
Integrations/src/main/java/io/deephaven/integrations/python/PythonReplayListenerAdapter.java
Show resolved
Hide resolved
Integrations/src/main/java/io/deephaven/integrations/python/PythonReplayListenerAdapter.java
Outdated
Show resolved
Hide resolved
chipkent
previously approved these changes
Jun 17, 2024
Integrations/src/main/java/io/deephaven/integrations/python/PythonReplayListenerAdapter.java
Outdated
Show resolved
Hide resolved
rcaudy
reviewed
Jun 17, 2024
Integrations/src/main/java/io/deephaven/integrations/python/PythonReplayListenerAdapter.java
Outdated
Show resolved
Hide resolved
rcaudy
reviewed
Jun 18, 2024
chipkent
reviewed
Jun 18, 2024
chipkent
reviewed
Jun 18, 2024
Co-authored-by: Chip Kent <5250374+chipkent@users.noreply.github.com>
Co-authored-by: Chip Kent <5250374+chipkent@users.noreply.github.com>
rcaudy
approved these changes
Jun 18, 2024
chipkent
approved these changes
Jun 18, 2024
Labels indicate documentation is required. Issues for documentation have been opened: Community: deephaven/deephaven-docs-community#238 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially Fixes #5366