Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a listener that only fires when all dependencies are satisfied #5571

Merged
merged 8 commits into from
Jun 18, 2024

Conversation

jmao-denver
Copy link
Contributor

@jmao-denver jmao-denver commented Jun 5, 2024

Partially Fixes #5366

@jmao-denver jmao-denver added this to the 3. May 2024 milestone Jun 5, 2024
@jmao-denver jmao-denver self-assigned this Jun 5, 2024
@jmao-denver jmao-denver force-pushed the 5366-multitable-listener branch 2 times, most recently from a3c8379 to f137328 Compare June 7, 2024 16:43
@jmao-denver jmao-denver marked this pull request as ready for review June 7, 2024 16:44
Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly reviewed Java, to avoid redundant work with Chip.

py/server/deephaven/table_listener.py Outdated Show resolved Hide resolved
py/server/deephaven/table_listener.py Outdated Show resolved Hide resolved
py/server/deephaven/table_listener.py Outdated Show resolved Hide resolved
py/server/deephaven/table_listener.py Outdated Show resolved Hide resolved
jmao-denver and others added 2 commits June 18, 2024 14:07
Co-authored-by: Chip Kent <5250374+chipkent@users.noreply.github.com>
Co-authored-by: Chip Kent <5250374+chipkent@users.noreply.github.com>
@jmao-denver jmao-denver merged commit f3cd3b4 into deephaven:main Jun 18, 2024
15 checks passed
@jmao-denver jmao-denver deleted the 5366-multitable-listener branch June 18, 2024 21:46
@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2024
@deephaven-internal
Copy link
Contributor

Labels indicate documentation is required. Issues for documentation have been opened:

Community: deephaven/deephaven-docs-community#238

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand the table listener interface to support listening on multiple source tables
4 participants