Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to GWT 2.11, clean up old gradle wiring #5576

Merged
merged 9 commits into from
Jun 8, 2024

Conversation

niloc132
Copy link
Member

@niloc132 niloc132 commented Jun 5, 2024

Precursor to changes for #188 - updating to GWT 2.11 will make it smoother to follow up with additional updates. The GWT 2.10 release changed the groupId from com.google.gwt to org.gwtproject, but our Gradle plugin does not support the new groupId, so this patch also rewrites automatic dependencies added by the plugin to use the new version.

Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there something driving this change? I can't remember and it's not apparent from the PR description/no ticket is linked.

buildSrc/src/main/groovy/GwtTools.groovy Show resolved Hide resolved
@niloc132
Copy link
Member Author

niloc132 commented Jun 6, 2024

There is nothing inherent about this change that is necessary right away, but deals with various updates that have been missed over the years, and readies us for the upcoming 2.12 release which will assist with #188 in a few ways, and also give us the ability to create sourcemap files with contents baked in (rather than packing up many individual source files).

@niloc132 niloc132 requested a review from mofojed June 6, 2024 22:06
buildSrc/src/main/groovy/GwtTools.groovy Outdated Show resolved Hide resolved
@niloc132 niloc132 requested a review from mofojed June 7, 2024 18:56
@niloc132 niloc132 merged commit 6512b0e into deephaven:main Jun 8, 2024
15 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants