Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SourceTable coalesce bug when indexed columns are dropped #5578

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Fix SourceTable coalesce bug when indexed columns are dropped #5578

merged 2 commits into from
Jun 5, 2024

Conversation

rcaudy
Copy link
Member

@rcaudy rcaudy commented Jun 5, 2024 •
edited

Fixes #5575

@rcaudy rcaudy added bug Something isn't working query engine core Core development tasks NoDocumentationNeeded ReleaseNotesNeeded Release notes are needed labels Jun 5, 2024
@rcaudy rcaudy added this to the 3. May 2024 milestone Jun 5, 2024
@rcaudy rcaudy self-assigned this Jun 5, 2024
@rcaudy rcaudy enabled auto-merge (squash) June 5, 2024 20:28
lbooker42
lbooker42 approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@lbooker42 lbooker42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rcaudy rcaudy merged commit 081793d into deephaven:main Jun 5, 2024
24 checks passed
@rcaudy rcaudy deleted the rwc-stdifix branch June 5, 2024 21:08
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lbooker42 lbooker42 lbooker42 approved these changes

@malhotrashivam malhotrashivam Awaiting requested review from malhotrashivam

Assignees

@rcaudy rcaudy

Labels
bug Something isn't working core Core development tasks NoDocumentationNeeded query engine ReleaseNotesNeeded Release notes are needed
Projects
None yet
Milestone
3. May 2024
Development

Successfully merging this pull request may close these issues.

DataIndex addition on SourceTable coalesce breaks if index columns are dropped via view
2 participants
@rcaudy @lbooker42