Optimizations in parquet file page materialization #5582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malhotrashivam
added
parquet
malhotrashivam
requested review from
chipkent,
jmao-denver and
rcaudy
as code owners
malhotrashivam
changed the title
malhotrashivam
changed the title
rcaudy
reviewed
Jun 13, 2024
replication/static/src/main/java/io/deephaven/replicators/ReplicatePageMaterializers.java
Outdated
Show resolved
Hide resolved
extensions/parquet/base/src/main/java/io/deephaven/parquet/base/PageMaterializer.java
Outdated
Show resolved
Hide resolved
extensions/parquet/base/src/main/java/io/deephaven/parquet/base/PageMaterializer.java
Outdated
Show resolved
Hide resolved
...uet/base/src/main/java/io/deephaven/parquet/base/materializers/LongPageMaterializerBase.java
Outdated
Show resolved
Hide resolved
...base/src/main/java/io/deephaven/parquet/base/materializers/InstantFromInt96Materializer.java
Outdated
Show resolved
Hide resolved
...base/src/main/java/io/deephaven/parquet/base/materializers/InstantFromInt96Materializer.java
Outdated
Show resolved
Hide resolved
|
|
||
| @Override | ||
| @NotNull | ||
| public final Class<LocalDate> getNativeType() { |
There was a problem hiding this comment.
This makes me wonder if we should just have a ToObjectPage with a type field. Then again, here we can use a singleton, which is nice. Maybe ignore me.
...ase/src/main/java/io/deephaven/parquet/base/materializers/LocalTimePageMaterializerBase.java
Outdated
Show resolved
Hide resolved
...et/base/src/main/java/io/deephaven/parquet/base/materializers/LocalDateTimeMaterializer.java
Outdated
Show resolved
Hide resolved
rcaudy
reviewed
Jun 17, 2024
...rc/main/java/io/deephaven/parquet/base/materializers/LocalDateTimeFromNanosMaterializer.java
Outdated
Show resolved
Hide resolved
...rc/main/java/io/deephaven/parquet/base/materializers/LocalDateTimeFromNanosMaterializer.java
Outdated
Show resolved
Hide resolved
rcaudy
reviewed
Jun 17, 2024
rcaudy
approved these changes
Jun 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original code, for non-primitive types like non-dictionary encoded Strings, LocalDate, etc., we read the bytes from the parquet file and convert it to binary data, and then later we convert the binary data to appropriate type, like String. This leads to extra memory allocation and extra copy for each value. After this PR, we will go directly from parquet file -> String in one step and that saves up to 10% in performance and significant improvements in memory utilization.
Same optimization has also been done for a few primitive types like char, short, and byte. For these types, we originally did parquet data -> int and int -> short/char/byte. Now we do directly parquet file -> short/char/byte