-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ExactMatch Filter for Non-Convertible Types; Use RangeFilter on QueryScope Vars #5587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcaudy
reviewed
Jun 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but we should also fix the missing parsing cases for LocalDate, LocalTime, LocalDateTime, and ZonedDateTime.
rcaudy
reviewed
Jun 7, 2024
engine/table/src/main/java/io/deephaven/engine/table/impl/select/MatchFilter.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/select/MatchFilter.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/select/MatchFilter.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/select/MatchFilter.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/select/MatchFilter.java
Outdated
Show resolved
Hide resolved
rcaudy
reviewed
Jun 14, 2024
engine/table/src/main/java/io/deephaven/engine/table/impl/select/MatchFilter.java
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/select/MatchFilter.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/select/MatchFilter.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/select/MatchFilter.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/select/MatchFilter.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/select/WhereFilterFactory.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/select/WhereFilterFactory.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/select/WhereFilterFactory.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/select/WhereFilterFactory.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/select/WhereFilterFactory.java
Show resolved
Hide resolved
rcaudy
reviewed
Jun 21, 2024
engine/table/src/main/java/io/deephaven/engine/table/impl/select/MatchFilter.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/select/MatchFilter.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/select/MatchFilter.java
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/select/MatchFilter.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/select/MatchFilter.java
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/select/RangeFilter.java
Outdated
Show resolved
Hide resolved
engine/table/src/test/java/io/deephaven/engine/table/impl/QueryTableWhereSingleTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Ryan Caudy <rcaudy@gmail.com>
rcaudy
reviewed
Jun 24, 2024
engine/table/src/main/java/io/deephaven/engine/table/impl/select/MatchFilter.java
Outdated
Show resolved
Hide resolved
rcaudy
reviewed
Jun 24, 2024
engine/table/src/main/java/io/deephaven/engine/table/impl/select/RangeFilter.java
Outdated
Show resolved
Hide resolved
rcaudy
previously approved these changes
Jun 24, 2024
rcaudy
previously approved these changes
Jun 24, 2024
engine/table/src/main/java/io/deephaven/engine/table/impl/select/MatchFilter.java
Outdated
Show resolved
Hide resolved
rcaudy
reviewed
Jun 24, 2024
engine/table/src/main/java/io/deephaven/engine/table/impl/select/MatchFilter.java
Outdated
Show resolved
Hide resolved
rcaudy
previously approved these changes
Jun 25, 2024
rcaudy
approved these changes
Jun 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
bug
Something isn't working
core
Core development tasks
NoDocumentationNeeded
query engine
release blocker
A bug/behavior that puts is below the "good enough" threshold to release.
ReleaseNotesNeeded
Release notes are needed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5584
Fixes #5526
Nightlies: https://github.com/nbauernfeind/deephaven-core/actions/runs/9665514128/