Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ExactMatch Filter for Non-Convertible Types; Use RangeFilter on QueryScope Vars #5587

Merged
merged 46 commits into from
Jun 25, 2024
Merged

Fix ExactMatch Filter for Non-Convertible Types; Use RangeFilter on QueryScope Vars #5587

merged 46 commits into from
Jun 25, 2024

Conversation

nbauernfeind
Copy link
Member

@nbauernfeind nbauernfeind commented Jun 7, 2024 •
edited

@nbauernfeind nbauernfeind added bug Something isn't working query engine core Core development tasks NoDocumentationNeeded ReleaseNotesNeeded Release notes are needed labels Jun 7, 2024
@nbauernfeind nbauernfeind added this to the 3. May 2024 milestone Jun 7, 2024
@nbauernfeind nbauernfeind requested a review from rcaudy June 7, 2024 17:06
@nbauernfeind nbauernfeind self-assigned this Jun 7, 2024
rcaudy
rcaudy reviewed Jun 7, 2024
View reviewed changes
Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but we should also fix the missing parsing cases for LocalDate, LocalTime, LocalDateTime, and ZonedDateTime.

@nbauernfeind nbauernfeind changed the title Fix ExactMatch Filter for Non-Convertible Types Fix ExactMatch Filter for Non-Convertible Types; Use RangeFilter on QueryScope Vars Jun 7, 2024
@nbauernfeind nbauernfeind requested a review from rcaudy June 7, 2024 20:05
rcaudy
rcaudy reviewed Jun 14, 2024
View reviewed changes
engine/table/src/main/java/io/deephaven/engine/table/impl/select/MatchFilter.java Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/select/MatchFilter.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/select/MatchFilter.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/select/MatchFilter.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/select/MatchFilter.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/select/WhereFilterFactory.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/select/WhereFilterFactory.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/select/WhereFilterFactory.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/select/WhereFilterFactory.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/select/WhereFilterFactory.java Show resolved Hide resolved
rcaudy
rcaudy reviewed Jun 21, 2024
View reviewed changes
engine/time/src/main/java/io/deephaven/time/DateTimeUtils.java Outdated Show resolved Hide resolved
engine/time/src/main/java/io/deephaven/time/DateTimeUtils.java Show resolved Hide resolved
engine/time/src/main/java/io/deephaven/time/DateTimeUtils.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/select/MatchFilter.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/select/MatchFilter.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/select/MatchFilter.java Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/select/MatchFilter.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/select/MatchFilter.java Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/select/RangeFilter.java Outdated Show resolved Hide resolved
engine/table/src/test/java/io/deephaven/engine/table/impl/QueryTableWhereSingleTest.java Outdated Show resolved Hide resolved
@nbauernfeind nbauernfeind requested a review from rcaudy June 24, 2024 18:44
rcaudy
rcaudy previously approved these changes Jun 24, 2024
View reviewed changes
@nbauernfeind nbauernfeind requested a review from rcaudy June 25, 2024 14:48
rcaudy
rcaudy previously approved these changes Jun 25, 2024
View reviewed changes
@nbauernfeind nbauernfeind merged commit f647f1a into deephaven:main Jun 25, 2024
15 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rcaudy rcaudy rcaudy approved these changes

Assignees

@nbauernfeind nbauernfeind

Labels
bug Something isn't working core Core development tasks NoDocumentationNeeded query engine release blocker A bug/behavior that puts is below the "good enough" threshold to release. ReleaseNotesNeeded Release notes are needed
Projects
None yet
Milestone
3. May 2024
2 participants
@nbauernfeind @rcaudy