Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an issue with boxed type arg matching and disable np scalar warnings for numba #5599

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Fix an issue with boxed type arg matching and disable np scalar warnings for numba #5599

merged 2 commits into from
Jun 11, 2024

Conversation

jmao-denver
Copy link
Contributor

Fixes #5594

@jmao-denver jmao-denver added this to the 3. May 2024 milestone Jun 11, 2024
@jmao-denver jmao-denver self-assigned this Jun 11, 2024
chipkent
chipkent reviewed Jun 11, 2024
View reviewed changes
py/server/deephaven/_udf.py Outdated Show resolved Hide resolved
py/server/tests/test_numba_guvectorize.py Show resolved Hide resolved
py/server/tests/test_numba_vectorized_column.py Show resolved Hide resolved
py/server/tests/test_numba_vectorized_column.py Outdated Show resolved Hide resolved
py/server/tests/test_udf_scalar_args.py Show resolved Hide resolved
py/server/tests/test_udf_scalar_args.py Show resolved Hide resolved
@jmao-denver jmao-denver merged commit 6654d5d into deephaven:main Jun 11, 2024
15 checks passed
@jmao-denver jmao-denver deleted the 5594-udf-arg-type-check branch June 11, 2024 16:37
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chipkent chipkent chipkent approved these changes

@rcaudy rcaudy Awaiting requested review from rcaudy rcaudy is a code owner

Assignees

@jmao-denver jmao-denver

Labels
NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. point_release_candidate python-server-side
Projects
None yet
Milestone
3. May 2024
Development

Successfully merging this pull request may close these issues.

Python query strings can not use a python float as a double when calling numba functions
3 participants
@jmao-denver @chipkent @rcaudy