fix: Modify getKeyColumns method for JsInputTable #5600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Working on resolving errors, and potentially changing logic / test cases. |
niloc132
reviewed
Jun 11, 2024
web/client-api/src/main/java/io/deephaven/web/client/api/input/JsInputTable.java
Outdated
Show resolved
Hide resolved
web/client-api/src/test/java/io/deephaven/web/client/api/InputTableTestGwt.java
Outdated
Show resolved
Hide resolved
|
Would it make sense to also update the valueColumns property? |
|
Not sure, @mofojed do you have any thoughts on that? |
AkshatJawne
added
NoDocumentationNeeded
NoReleaseNotesNeeded
niloc132
reviewed
Jun 12, 2024
web/client-api/src/main/java/io/deephaven/web/client/state/ClientTableState.java
Outdated
Show resolved
Hide resolved
niloc132
approved these changes
Jun 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5557
Changes Implemented:
JsInputTable.getKeyColumnsandJsInputTable.getValueColumnsreturn a Frozen/Stable Array similar to theJsTable.getColumnsInputTableTestGwt) with unit tests that check both methods