Fix csv.py parser mappings #5602
Conversation
Related to deephaven#5601
|
This is incomplete, because it looks like there is a bug in the underlying deephaven-csv layer. See the issue for details. |
devinrsmith
added
NoDocumentationNeeded
ReleaseNotesNeeded
devinrsmith
requested review from
chipkent,
jmao-denver and
rcaudy
as code owners
|
My earlier assessment that there was a bug in the lower layer only applies to reserved keywords as column names. Will file a bug there. |
| @@ -75,9 +75,9 @@ def read( | |||
| dht.byte: _JParsers.BYTE, | |||
| dht.char: _JParsers.CHAR, | |||
| dht.short: _JParsers.SHORT, | |||
| dht.int64: _JParsers.INT, | |||
There was a problem hiding this comment.
This disables support for dht.int64 and dht.float64. That seems more accurate, but how many users will it affect?
There was a problem hiding this comment.
dht.int64 == dht.long, dht.float64 == dht.double; they are present lower down in the map.
There was a problem hiding this comment.
I'm afraid I don't see dht.int64, dht.float64, dht.int16 or dht.int8 anywhere in this file. What file is that in?
There was a problem hiding this comment.
I think I see it. This is an object map, so you only need one variable that points to the object to be represented. So in dtypes.py, both int64 and long point to the same DType object, so you only need one represented in the map.
| @@ -75,9 +75,9 @@ def read( | |||
| dht.byte: _JParsers.BYTE, | |||
| dht.char: _JParsers.CHAR, | |||
| dht.short: _JParsers.SHORT, | |||
| dht.int64: _JParsers.INT, | |||
| dht.int32: _JParsers.INT, | |||
| dht.long: _JParsers.LONG, | |||
There was a problem hiding this comment.
Do int64 and float64 correctly map to long and double?
There was a problem hiding this comment.
yes, they are the same objects.
| @@ -75,9 +75,9 @@ def read( | |||
| dht.byte: _JParsers.BYTE, | |||
| dht.char: _JParsers.CHAR, | |||
| dht.short: _JParsers.SHORT, | |||
| dht.int64: _JParsers.INT, | |||
There was a problem hiding this comment.
I'm afraid I don't see dht.int64, dht.float64, dht.int16 or dht.int8 anywhere in this file. What file is that in?
| @@ -75,9 +75,9 @@ def read( | |||
| dht.byte: _JParsers.BYTE, | |||
| dht.char: _JParsers.CHAR, | |||
| dht.short: _JParsers.SHORT, | |||
| dht.int64: _JParsers.INT, | |||
There was a problem hiding this comment.
I think I see it. This is an object map, so you only need one variable that points to the object to be represented. So in dtypes.py, both int64 and long point to the same DType object, so you only need one represented in the map.
Fixes #5601