Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: statistical functions should return null when provided a vector of only null values #5606

Merged
merged 19 commits into from
Jun 19, 2024
Merged

fix!: statistical functions should return null when provided a vector of only null values #5606

merged 19 commits into from
Jun 19, 2024

Commits on Jun 11, 2024

  1. Updated Numeric calculations and tests, corrected median and percenti… 

    …le to ignore NULL values.
    @lbooker42
    lbooker42 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    076e286 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Correct Numeric avg() function and tests.

    @lbooker42
    lbooker42 committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    dd9f507 View commit details
    Browse the repository at this point in the history

  2. UpdateBy corrections for all-NULL vectors

    @lbooker42
    lbooker42 committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    5bf465e View commit details
    Browse the repository at this point in the history

  3. Agg corrections for avg,var,std

    @lbooker42
    lbooker42 committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    ad2675d View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. Agg test changes to reflect new output.

    @lbooker42
    lbooker42 committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    50667f2 View commit details
    Browse the repository at this point in the history

  2. Spotless

    @lbooker42
    lbooker42 committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    ff6f010 View commit details
    Browse the repository at this point in the history

  3. Tiny change for correctness.

    @lbooker42
    lbooker42 committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    9ff3cf6 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. Addressed PR comments.

    @lbooker42
    lbooker42 committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    8753267 View commit details
    Browse the repository at this point in the history

  2. Addressed another round of PR comments.

    @lbooker42
    lbooker42 committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    4481f79 View commit details
    Browse the repository at this point in the history

  3. More comments addressed.

    @lbooker42
    lbooker42 committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    9422488 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Bug fix to pass OOB.

    @lbooker42
    lbooker42 committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    5750546 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into lab-numeric-harmony

    @lbooker42
    lbooker42 committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    b06a063 View commit details
    Browse the repository at this point in the history

  3. Spotless

    @lbooker42
    lbooker42 committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    35c03d1 View commit details
    Browse the repository at this point in the history

  4. Undo test commenting.

    @lbooker42
    lbooker42 committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    0f150ac View commit details
    Browse the repository at this point in the history

  5. Better testing and coverage, fix to wvar() and misc cleanup.

    @lbooker42
    lbooker42 committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    4e01d9d View commit details
    Browse the repository at this point in the history

  6. Test correction.

    @lbooker42
    lbooker42 committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    2ea6418 View commit details
    Browse the repository at this point in the history

  7. Removed dead code.

    @lbooker42
    lbooker42 committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    e00e49a View commit details
    Browse the repository at this point in the history

  8. Update engine/function/src/templates/Numeric.ftl 

    Accepting PR suggestions

Co-authored-by: Ryan Caudy <rcaudy@gmail.com>
    @lbooker42 @rcaudy
    lbooker42 and rcaudy committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    6bf8bb9 View commit details
    Browse the repository at this point in the history

  9. Update engine/function/src/templates/Numeric.ftl 

    Accepting PR suggestions

Co-authored-by: Ryan Caudy <rcaudy@gmail.com>
    @lbooker42 @rcaudy
    lbooker42 and rcaudy committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    cf1f22e View commit details
    Browse the repository at this point in the history