fix: signal.pause is not available on Windows #5618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mofojed
commented
Jun 15, 2024
•
mofojed
commented
- Use os.system("pause") instead on Windows
- Need to test on Windows
- Fixes Embedded server CLI won't work on windows without WSL #5525
devinrsmith
reviewed
Jun 17, 2024
mofojed
added
NoDocumentationNeeded
NoReleaseNotesNeeded
chipkent
previously approved these changes
Jun 17, 2024
- Use os.system("pause") instead on Windows
- Need to test on Windows
- Seems to work correctly in testing
- Simplifies the logic for both Windows and Unix based systems - Seems to have no other side effects
mofojed
force-pushed
the
5525-signal-pause
branch
from
68215a4
to
276ba3a
Compare
chipkent
approved these changes
Jun 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.