ci: Publish jsapi-types patch release with v0.33 tag

[mofojed]

• Should no longer clobber the latest tag
• rc/v0.33.x workaround for Patch releases of jsapi-types getting dist-tag latest incorrectly #5572

[devinrsmith]

I would call this is a workaround for #5572 as opposed to a "fix"; ideally, we'd plumb appropriate metadata through the job to handle this more generally.

[mofojed]

I'll make a more general workaround and put it on main using the branch name.

[devinrsmith]

To make sure I understand a bit more: a tag here is not the same as npm "version" - it's an additional qualifier that points to a version?

Can a single version have multiple tags?

Looking at https://www.npmjs.com/package/@deephaven/jsapi-types?activeTab=versions, I see the tags latest, nightly, and canary. Are we planning to introduce a new convention for all npm releases, with a tag that is v<major>.<minor>?

https://docs.npmjs.com/adding-dist-tags-to-packages seems to recommend against this:

We recommend avoiding dist-tags that start with a number or the letter "v".

[mofojed]

Correct; we do the v<major>.<minor> tagging on the web-client-ui packages: https://www.npmjs.com/package/@deephaven/code-studio?activeTab=versions
But it could be any arbitrary name. Yea npm recommends against it, but not sure what else to name them? We could give them the same name as the Enterprise releases they coincide with (e.g. vplus), and maybe that would be a better fit (though ironically still wouldn't be recommended, since it starts with v)?

[mofojed]

@devinrsmith actually I'm not sure I can make a more general case with how the release process is right now - it only publishes when the ref matches release/v*: if: ${{ startsWith(github.ref, 'refs/heads/release/v') }}

I don't think there's a way (yet) to distinguish between a main/latest release vs. a patch on a previous release, as at this point it's already a release/v* branch only.

[devinrsmith]

@devinrsmith actually I'm not sure I can make a more general case with how the release process is right now - it only publishes when the ref matches release/v*: if: ${{ startsWith(github.ref, 'refs/heads/release/v') }}

I don't think there's a way (yet) to distinguish between a main/latest release vs. a patch on a previous release, as at this point it's already a release/v* branch only.

The more general solution we should discuss relative to #5631