Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ErrorTransformer: prevent NPE #5633

Merged
merged 3 commits into from
Jun 21, 2024
Merged

ErrorTransformer: prevent NPE #5633

merged 3 commits into from
Jun 21, 2024

Conversation

nbauernfeind
Copy link
Member

Fixes #5596.

@nbauernfeind nbauernfeind added bug Something isn't working core Core development tasks NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. labels Jun 18, 2024
@nbauernfeind nbauernfeind requested a review from rcaudy June 18, 2024 15:58
@nbauernfeind nbauernfeind self-assigned this Jun 18, 2024
rcaudy
rcaudy reviewed Jun 18, 2024
View reviewed changes
Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are good. We should add a transform check to list flights for scope vars, and standardize our errors a bit.

server/src/main/java/io/deephaven/server/appmode/ApplicationTicketResolver.java Show resolved Hide resolved
server/src/main/java/io/deephaven/server/console/ScopeTicketResolver.java Outdated Show resolved Hide resolved
server/src/main/java/io/deephaven/server/console/ScopeTicketResolver.java Show resolved Hide resolved
server/src/main/java/io/deephaven/server/session/SharedTicketResolver.java Outdated Show resolved Hide resolved
@nbauernfeind nbauernfeind requested a review from rcaudy June 18, 2024 23:24
@rcaudy rcaudy added the release blocker A bug/behavior that puts is below the "good enough" threshold to release. label Jun 20, 2024
@nbauernfeind nbauernfeind requested a review from rcaudy June 21, 2024 17:24
@nbauernfeind nbauernfeind merged commit a9ebacf into deephaven:main Jun 21, 2024
15 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rcaudy rcaudy rcaudy approved these changes

Assignees

@nbauernfeind nbauernfeind

Labels
bug Something isn't working core Core development tasks NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. release blocker A bug/behavior that puts is below the "good enough" threshold to release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Table Transformer Callers should Expect null return value
2 participants
@nbauernfeind @rcaudy