Allow extra headers in Barrage session creation #5637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arman-ddl
added
barrage
NoDocumentationNeeded
python-client
NoReleaseNotesNeeded
jmao-denver
reviewed
Jun 18, 2024
devinrsmith
reviewed
Jun 18, 2024
jmao-denver
reviewed
Jun 18, 2024
rcaudy
added
the
release blocker
rcaudy
requested changes
Jun 20, 2024
jmao-denver
reviewed
Jun 20, 2024
py/server/tests/test_barrage.py
Outdated
| @@ -59,7 +59,7 @@ def tearDown(self) -> None: | |||
| self.pub_session.close() | |||
|
|
|||
| def test_barrage_session(self): | |||
| session = barrage_session(host="localhost", port=10000, auth_type="Anonymous") | |||
| session = barrage_session(host="localhost", port=10000, auth_type="Anonymous", extra_headers={"envoy-prefix": "test"}) | |||
There was a problem hiding this comment.
Interesting choice of the header name, I thought in a cluster deployment, a server-server connection doesn't involve envoy.
There was a problem hiding this comment.
I'd also like to add a test method such as def test_barrage_session_with_extra_headers instead of modifying the existing one.
There was a problem hiding this comment.
The intended and tested use case (in Core+) is client-server where "client" is outside of "server"'s cluster. Feel free to change header to whatever is better suited for Core tests. I just chose what was familiar.
There was a problem hiding this comment.
I moved the change to its own test as suggested.
rcaudy
approved these changes
Jun 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Satisfies #5636.