Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove latest symlink for docs-ci-v2 #5641

Merged

Conversation

devinrsmith
Copy link
Member

Note: docs-ci-v2 is no longer present in main, but is applicable for 0.33.x releases.

Workaround for #5591

Note: docs-ci-v2 is no longer present in main, but is applicable for 0.33.x releases.

Workaround for deephaven#5591
Copy link
Contributor

@stanbrub stanbrub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. I think this will work, because we are using --delete in the rsync.

@devinrsmith
Copy link
Member Author

Good idea. I think this will work, because we are using --delete in the rsync.

Do you think this means we will delete the latest symlink on the remote? If that's the case, that's probably not what we want?

@devinrsmith
Copy link
Member Author

Do you mean:

because we are not using --delete in the rsync

?

@stanbrub
Copy link
Contributor

stanbrub commented Jun 20, 2024

Do you mean:

because we are not using --delete in the rsync

?

Yes. Sorry. For the symlinks, we are not using the --delete tag, so it shouldn't delete the latest link.

@devinrsmith devinrsmith merged commit e999826 into deephaven:rc/v0.33.x Jun 20, 2024
18 checks passed
@devinrsmith devinrsmith deleted the docs-ci-latest-workaround branch June 20, 2024 17:54
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants