Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate arg type for sort/partition_by #5652

Merged
merged 2 commits into from
Jun 22, 2024

Conversation

jmao-denver
Copy link
Contributor

Fixes #5455
Fixes #5651

chipkent
chipkent previously approved these changes Jun 21, 2024
rcaudy
rcaudy previously approved these changes Jun 21, 2024
@jmao-denver jmao-denver enabled auto-merge (squash) June 21, 2024 20:02
@jmao-denver jmao-denver dismissed stale reviews from rcaudy and chipkent via d7bd218 June 21, 2024 23:44
@jmao-denver jmao-denver merged commit ffec8b7 into deephaven:main Jun 22, 2024
15 checks passed
@jmao-denver jmao-denver deleted the 5455-5651-check-arg-types branch June 22, 2024 00:44
@github-actions github-actions bot locked and limited conversation to collaborators Jun 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table.partition_by() wrongly accepts two string args sort doesn't check the value passed in as the order
3 participants