Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct OOB test failures from mismatching Iceberg API table column names #5662

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

lbooker42
Copy link
Contributor

#5590 merged with broken Iceberg tests:

  • IcebergToolsTest.#testListNamespaces
  • IcebergToolsTest.#testListTables
  • IcebergToolsTest.#testListSnapshots

This PR corrects the tests to match the implementation column names.

@lbooker42 lbooker42 added bug Something isn't working NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. labels Jun 24, 2024
@lbooker42 lbooker42 added this to the June 2024 milestone Jun 24, 2024
@lbooker42 lbooker42 requested a review from rcaudy June 24, 2024 23:34
@lbooker42 lbooker42 self-assigned this Jun 24, 2024
@lbooker42 lbooker42 changed the title fix: corrected OOB test failures from mismatching Iceberg API table column names fix: correct OOB test failures from mismatching Iceberg API table column names Jun 24, 2024
@lbooker42 lbooker42 merged commit 8f312d1 into deephaven:main Jun 25, 2024
21 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2024
@lbooker42 lbooker42 deleted the lab-iceberg-fix branch June 26, 2024 19:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants