feat: reduce included dependencies for Iceberg implementation #5668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbooker42
added
NoDocumentationNeeded
NoReleaseNotesNeeded
rcaudy
previously approved these changes
Jun 25, 2024
devinrsmith
reviewed
Jun 26, 2024
extensions/iceberg/build.gradle
Outdated
| @@ -23,6 +23,7 @@ dependencies { | |||
|
|
|||
| Classpaths.inheritIcebergCore(project) | |||
| Classpaths.inheritIcebergHadoop(project) | |||
| Classpaths.inheritAvro(project, JavaPlugin.IMPLEMENTATION_CONFIGURATION_NAME) | |||
There was a problem hiding this comment.
What was the specific error when this was not included?
It seems like we should be marking this as runtimeOnly instead? Maybe best to move into one of the added-back-in dependencies with a "because" reason in inheritParquetHadoopConfiguration.
There was a problem hiding this comment.
The error is:
/Users/larrybooker/dhc/lab-reduce-dep/extensions/iceberg/src/main/java/io/deephaven/iceberg/layout/IcebergKeyValuePartitionedLayout.java:91: error: cannot access IndexedRecord
final PartitionData partitionData = (PartitionData) df.partition();
^
class file for org.apache.avro.generic.IndexedRecord not found
/Users/larrybooker/dhc/lab-reduce-dep/extensions/iceberg/src/main/java/io/deephaven/iceberg/layout/IcebergKeyValuePartitionedLayout.java:94: error: cannot access SpecificData
final Object colValue = partitionData.get(colData.index);
^
class file for org.apache.avro.specific.SpecificData not found
Note: /Users/larrybooker/dhc/lab-reduce-dep/extensions/iceberg/src/main/java/io/deephaven/iceberg/util/IcebergCatalogAdapter.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
2 errors
There was a problem hiding this comment.
Interesting; I wonder why iceberg doesn't declare this as an API dependency... I might file an issue with them.
devinrsmith
previously approved these changes
Jun 26, 2024
extensions/iceberg/build.gradle
Outdated
| @@ -23,6 +23,7 @@ dependencies { | |||
|
|
|||
| Classpaths.inheritIcebergCore(project) | |||
| Classpaths.inheritIcebergHadoop(project) | |||
| Classpaths.inheritAvro(project, JavaPlugin.IMPLEMENTATION_CONFIGURATION_NAME) | |||
There was a problem hiding this comment.
Interesting; I wonder why iceberg doesn't declare this as an API dependency... I might file an issue with them.
devinrsmith
previously approved these changes
Jun 26, 2024
devinrsmith
reviewed
Jun 26, 2024
devinrsmith
reviewed
Jun 26, 2024
devinrsmith
requested changes
Jun 26, 2024
devinrsmith
approved these changes
Jun 26, 2024
rcaudy
approved these changes
Jun 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.