-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instant Column gRPC Filters: Fix Range Quick Filters and use MatchFilter over ConditionFilter #5671
Conversation
server/src/main/java/io/deephaven/server/table/ops/filter/FilterFactory.java
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/table/ops/filter/FilterFactory.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Tested by opening up a time table, opening a quick filter in the Timestamp slot, and entering 2024
.
format.setDecimalSeparatorAlwaysShown(false); | ||
format.setGroupingUsed(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the new approach mitigate the same issues?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
9ece811
to
bb200f8
Compare
Fixes the error hit when quick filtering through the web-ui: