Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instant Column gRPC Filters: Fix Range Quick Filters and use MatchFilter over ConditionFilter #5671

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

nbauernfeind
Copy link
Member

Fixes the error hit when quick filtering through the web-ui:

Internal Error '1c813e17-8191-4f29-8680-4fc9991b6a2a' java.lang.IllegalArgumentException: Failed to convert literal value <1719427193000000000> for column "Timestamp" of type java.time.Instant
	at io.deephaven.engine.table.impl.select.MatchFilter$ColumnTypeConvertor.convertValue(MatchFilter.java:382)
	at io.deephaven.engine.table.impl.select.RangeFilter.init(RangeFilter.java:185)
	at io.deephaven.engine.table.impl.QueryTable.initializeAndPrioritizeFilters(QueryTable.java:1175)
	at io.deephaven.engine.table.impl.QueryTable.lambda$whereInternal$29(QueryTable.java:1225)
	at io.deephaven.engine.table.impl.perf.QueryPerformanceRecorder.withNugget(QueryPerformanceRecorder.java:369)
	at io.deephaven.engine.table.impl.QueryTable.whereInternal(QueryTable.java:1223)
	at io.deephaven.engine.table.impl.QueryTable.where(QueryTable.java:1162)
	at io.deephaven.engine.table.impl.QueryTable.where(QueryTable.java:100)
	at io.deephaven.server.table.ops.FilterTableGrpcImpl.create(FilterTableGrpcImpl.java:57)
	at io.deephaven.server.table.ops.FilterTableGrpcImpl.create(FilterTableGrpcImpl.java:30)
	at io.deephaven.server.table.ops.TableServiceGrpcImpl$BatchExportBuilder.doExport(TableServiceGrpcImpl.java:757)
	at io.deephaven.server.session.SessionState$ExportObject.doExport(SessionState.java:995)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630)
	at io.deephaven.server.runner.scheduler.SchedulerModule$ThreadFactory.lambda$newThread$0(SchedulerModule.java:100)
	at java.base/java.lang.Thread.run(Thread.java:832)
Caused by: java.lang.IllegalArgumentException: Instant literal not enclosed in single-quotes ("1719427193000000000")
	at io.deephaven.engine.table.impl.select.MatchFilter$ColumnTypeConvertorFactory$13.convertStringLiteral(MatchFilter.java:720)
	at io.deephaven.engine.table.impl.select.MatchFilter$ColumnTypeConvertor.convertValue(MatchFilter.java:380)
	... 18 more

@nbauernfeind nbauernfeind added bug Something isn't working web-client-ui The Web GUI grpc core Core development tasks release blocker A bug/behavior that puts is below the "good enough" threshold to release. labels Jun 26, 2024
@nbauernfeind nbauernfeind self-assigned this Jun 26, 2024
mofojed
mofojed previously approved these changes Jun 26, 2024
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Tested by opening up a time table, opening a quick filter in the Timestamp slot, and entering 2024.

niloc132
niloc132 previously approved these changes Jun 26, 2024
devinrsmith
devinrsmith previously approved these changes Jun 26, 2024
Comment on lines 131 to 132
format.setDecimalSeparatorAlwaysShown(false);
format.setGroupingUsed(false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the new approach mitigate the same issues?

Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@nbauernfeind nbauernfeind enabled auto-merge (squash) June 26, 2024 23:34
@nbauernfeind nbauernfeind merged commit 98b62cb into deephaven:main Jun 26, 2024
14 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working core Core development tasks grpc NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. release blocker A bug/behavior that puts is below the "good enough" threshold to release. web-client-ui The Web GUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants