Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make TableListenerHandle a JObjectWrapper again #5713

Merged

Conversation

jmao-denver
Copy link
Contributor

So that it can be directly added to LivenessScope

Fixes #5711

@jmao-denver jmao-denver added this to the 0.36.0 milestone Jul 3, 2024
@jmao-denver jmao-denver self-assigned this Jul 3, 2024
@jmao-denver jmao-denver changed the title Make TabeListenerHandle a JObjectWrapper again fix: make TabeListenerHandle a JObjectWrapper again Jul 3, 2024
@jmao-denver jmao-denver added ReleaseNotesNeeded Release notes are needed and removed NoReleaseNotesNeeded No release notes are needed. labels Jul 3, 2024
@jmao-denver jmao-denver removed this from the 0.36.0 milestone Jul 3, 2024
@niloc132 niloc132 changed the title fix: make TabeListenerHandle a JObjectWrapper again fix: make TableListenerHandle a JObjectWrapper again Jul 5, 2024
@jmao-denver jmao-denver merged commit 2d6bf4b into deephaven:main Jul 6, 2024
26 of 29 checks passed
@jmao-denver jmao-denver deleted the 5711-TableListener-JObjectWrapper branch July 6, 2024 00:30
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LivenessScope can't manage TableListenerHandle directly
3 participants