refactor: Remove Math.nextUp call in QueryConstants #5747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Math.nextUp is not presently usable in GWT, so this patch lets the JS API share QueryConstants and ensures that the MIN_FINITE values are correct, without actually initializing them via a call to Math.nextUp. Partial deephaven#188
niloc132
added
NoDocumentationNeeded
ReleaseNotesNeeded
rcaudy
reviewed
Jul 10, 2024
engine/query-constants/src/main/java/io/deephaven/util/QueryConstants.java
Outdated
Show resolved
Hide resolved
engine/query-constants/src/main/java/io/deephaven/util/QueryConstants.java
Outdated
Show resolved
Hide resolved
engine/query-constants/src/test/java/io/deephaven/util/QueryConstantsTest.java
Outdated
Show resolved
Hide resolved
engine/query-constants/src/test/java/io/deephaven/util/QueryConstantsTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Ryan Caudy <rcaudy@gmail.com>
rcaudy
approved these changes
Jul 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Math.nextUp is not presently usable in GWT, so this patch lets the JS API share QueryConstants and ensures that the MIN_FINITE values are correct, without actually initializing them via a call to Math.nextUp.
Partial #188