refactor!: Rearrange TypeUtils and ArrayTypeUtils so they can be shared with JS API #5780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niloc132
added
NoDocumentationNeeded
breaking
ReleaseNotesNeeded
niloc132
force-pushed
the
188-typeutils-pruning
branch
from
7e612ba
to
a8c9352
Compare
rcaudy
reviewed
Jul 16, 2024
engine/table/src/test/java/io/deephaven/engine/util/TestTypeUtils.java
Outdated
Show resolved
Hide resolved
Util/src/main/java/io/deephaven/util/type/NumericTypeUtils.java
Outdated
Show resolved
Hide resolved
devinrsmith
reviewed
Jul 16, 2024
devinrsmith
previously approved these changes
Jul 17, 2024
rcaudy
reviewed
Jul 18, 2024
rcaudy
approved these changes
Jul 19, 2024
| columnSource = ReinterpretUtils.instantToLongSource(table.getColumnSource(columnName)); | ||
| } else if (type == ZonedDateTime.class) { | ||
| statsFunc = new DateTimeChunkedStats(); | ||
| columnSource = ReinterpretUtils.zonedDateTimeToLongSource(table.getColumnSource(columnName)); |
There was a problem hiding this comment.
Fun fact, this is going to work, but it has implications. That is, it assumes that all ZDTs that map to the same Instant are equal, which isn't so according to ZDT.equals(). Not a thing to address here, now, but certainly a concern.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed some unused methods, rewrote some implementations to avoid reflection where unnecessary, removed ObjectInputStream/ObjectOutputStream usage.
BREAKING CHANGES: Moved isBoxedNumeric, isNumeric, isBigNumeric to NumericTypeUtils, removed @IsDateTime, removed other reflective methods from TypeUtils and ArrayTypeUtils.
Partial #188