fix(cpp-client): deephavenConfig.cmake provides transitive dependencies #5792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcferretti
added
NoDocumentationNeeded
NoReleaseNotesNeeded
kosak
previously approved these changes
Jul 18, 2024
devinrsmith
approved these changes
Jul 18, 2024
kosak
approved these changes
Jul 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I modified the deephaven_enterprise C++ client cmake code to remove the explicit requirements for dependencies that are only transitive and PRIVATE from deephaven (core) C++ client cmake (eg, Immer). The new config file allowed those to be removed in the DHE side.
The new code in the toplevel CMakeLists.txt for deephaven was inspired by the cmake doc here:
https://cmake.org/cmake/help/latest/manual/cmake-packages.7.html#creating-packages
and
https://cmake.org/cmake/help/latest/manual/cmake-packages.7.html#creating-a-package-configuration-file