Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Codec-api should support java8 for Enterprise #5828

Merged
merged 1 commit into from
Jul 23, 2024
Merged

feat: Codec-api should support java8 for Enterprise #5828

merged 1 commit into from
Jul 23, 2024

Conversation

abaranec
Copy link
Contributor

Fixes #5827

@abaranec abaranec added this to the 0.35.2 milestone Jul 22, 2024
@abaranec abaranec self-assigned this Jul 22, 2024
@devinrsmith devinrsmith self-requested a review July 22, 2024 21:59
devinrsmith
devinrsmith approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@devinrsmith devinrsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; we have safety checks to make sure that the java 8 depenencies don't depend on non java 8 compatible projects, so success of CI should give us confidence this is OK.

@abaranec abaranec merged commit 3b00439 into deephaven:main Jul 23, 2024
18 of 21 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devinrsmith devinrsmith devinrsmith approved these changes

Assignees

@abaranec abaranec

Labels
NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed.
Projects
None yet
Milestone
0.35.2
Development

Successfully merging this pull request may close these issues.

New Codec-api module should support java 8
2 participants
@abaranec @devinrsmith