feat(cpp-client): Add GetTidAsString as a utility function #5843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosak
added
NoDocumentationNeeded
NoReleaseNotesNeeded
jcferretti
previously approved these changes
Jul 24, 2024
jcferretti
approved these changes
Jul 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
GetTidAsString()as a utility function.Note that the previous version of this code was
inline. However, on the Windows platform, making it inline involves pulling in some windows includes includingwindows.h. The problem with includingwindows.his that it defines some macros that might conflict. In particular it defines theminandmaxmacros that definitely conflict.In order to free ourselves and our Windows customers from seeing the conflicts that might arise, we isolate the Windows-specific code in a .cc file rather than including
windows.hin a .h file.There are other approaches that would work too, such as defining
NOMINMAXor changing all of our calls that look likemin()andmax()to have extra parentheses:(min)()and(max)().However in my opinion, isolating this Windows-specific code in one .cc file was simplest for now.