fix: Make Java, Python wheel artifacts have same dependencies #5850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niloc132
added
NoDocumentationNeeded
ReleaseNotesNeeded
niloc132
commented
Jul 26, 2024
| @@ -27,6 +27,10 @@ dependencies { | |||
| runtimeOnly project(':hotspot-impl') | |||
| } | |||
|
|
|||
| if (!hasProperty('excludeClockImpl')) { | |||
There was a problem hiding this comment.
This was also missing, but the server impl explicitly assumes it is there in its jvm args.
rcaudy
previously approved these changes
Jul 26, 2024
chipkent
previously approved these changes
Jul 26, 2024
niloc132
force-pushed
the
5848-py-server-json
branch
from
8aae914
to
dc40ddb
Compare
|
Added a test that will fail without the fix, so that we get early warnings about this kind of problem in the future. This ends up downloading a few wheels when the test runs, not unlike how the py-client tests behave - we may want to see about pinning those in our base images, so that the tests run much faster. This also required a fix to stream.py, as the xmlrunner provides a stream for stdout/err that apparently includes an |
chipkent
approved these changes
Jul 26, 2024
jmao-denver
approved these changes
Jul 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5848