Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update snapshot_when doc with trigger table being append-only requirement when history is requested. #5853

Merged
merged 2 commits into from
Aug 5, 2024
Merged

fix: update snapshot_when doc with trigger table being append-only requirement when history is requested. #5853

merged 2 commits into from
Aug 5, 2024

Conversation

jmao-denver
Copy link
Contributor

Fixes #5841

@jmao-denver jmao-denver added this to the 0.36.0 milestone Jul 26, 2024
@jmao-denver jmao-denver self-assigned this Jul 26, 2024
chipkent
chipkent previously approved these changes Jul 26, 2024
View reviewed changes
rcaudy
rcaudy requested changes Jul 26, 2024
View reviewed changes
Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't merge this. If we want something like this, we should be changing the Java code to use withAttribute on the trigger table.

py/server/deephaven/table.py Outdated Show resolved Hide resolved
@jmao-denver jmao-denver force-pushed the 5841-snapshot-when-append-only-trigger branch from 4c8d01a to 227ee75 Compare July 29, 2024 16:50
@jmao-denver jmao-denver changed the title fix: Check if trigger table is append only when history is True in snapshot_when fix: update snapshot_when doc with trigger table being append-only requirement when history is requested. Jul 29, 2024
@rcaudy rcaudy requested a review from devinrsmith August 2, 2024 18:22
@jmao-denver jmao-denver merged commit 74cd34a into deephaven:main Aug 5, 2024
17 checks passed
@jmao-denver jmao-denver deleted the 5841-snapshot-when-append-only-trigger branch August 5, 2024 23:14
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chipkent chipkent chipkent approved these changes

@rcaudy rcaudy rcaudy approved these changes

@devinrsmith devinrsmith devinrsmith approved these changes

Assignees

@jmao-denver jmao-denver

Labels
NoDocumentationNeeded ReleaseNotesNeeded Release notes are needed
Projects
None yet
Milestone
0.36.0
Development

Successfully merging this pull request may close these issues.

snapshot_when history might need some kind of re-design
4 participants
@jmao-denver @chipkent @rcaudy @devinrsmith